chore: upgrade tasks to node 20 #225
Conversation
lstocchi
force-pushed
the
migrateNode20
branch
7 times, most recently
from
3d8dca8 to
1e59b91
Compare
Signed-off-by: lstocchi <[email protected]>
lstocchi
force-pushed
the
migrateNode20
branch
from
1e59b91 to
008a13c
Compare
| @@ -39,7 +39,7 @@ jobs: | |||
| - name: Setup Node.js environment | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: '10.x' | |||
| node-version: '20.x' | |||
There was a problem hiding this comment.
Excuse my ignorance, I'm not really familiar with this repo and Github workflows.
But why the version is hard coded in here instead of "node-version: ${{ matrix.node }}" like on line 28?
If my question doesn't make sense, please feel free to ignore me :)
There was a problem hiding this comment.
There is no strong opinion to why a hard coded version is better than a matrix in this case and it could be changed. Obviously, in general cases, running many matrix tests is more expensive. In this case, the tests are minimal .... it just runs matrix on linux to identify some potential errors with a specific version of node (to see if some func has been deprecated/removed and the code break), and on win/Mac just targets the version which should be used at runtime.
I'm not working with azure devops anymore (I left this field 3+ years ago) so I'm not really updated about it but it seems they recommend node 20. This is why I changed it
There was a problem hiding this comment.
Ah makes sense, much appreciated!
No description provided.